Carsten Lohmann comments

Results 102 comments of


                                            Carsten Lohmann

The uri() method and the absoluteURI() method in HttpServerRequestImpl are inconsistent in judging the legality of uri.

> we don't do validation on purpose If validation isn't needed here, then my intuition would be that the existing code https://github.com/eclipse-vertx/vert.x/blob/cbf38bfc2cfcceb4ccbae89ba6619f0a5158dff8/src/main/java/io/vertx/core/http/impl/HttpUtils.java#L364-L379 could be adapted by replacing ```` URI uri...

The uri() method and the absoluteURI() method in HttpServerRequestImpl are inconsistent in judging the legality of uri.

@vietj Any thoughts on the above? Doing the "startsWith("http(s)://" check instead of parsing the URI to check for an absolute URI.

Request Timeout should start after the connection is stabilished

I would also opt for such a request timeout value. Consider this example: ```` vertx.createHttpServer().requestHandler(req -> { logger.info("serverside: got req " + req.path()); if (req.path().contains("slow")) { vertx.setTimer(3000, h -> req.response().end("foo"));...

[#2809] Prevent unhandled MongoDB client exceptions

Right, I misinterpreted the stacktrace here.

[#2809] Prevent unhandled MongoDB client exceptions

I've removed the changes wrapping the MongoDB client operation now. Instead, the existing `mapError` method has been adapted and a new `logError` method has been added.

Kafka telemetry producer may reach state where OUT_OF_ORDER_SEQUENCE_NUMBER errors get thrown

Log entries corresponding to the recurring errors: ``` Jan 1, 2022 @ 23:38:56.310 WARN org.apache.kafka.clients.producer.internals.Sender [Producer clientId=hono-cmd-router-internal-cmd-sender-uuid] Got error produce response with correlation id 55429 on topic-partition hono.command_internal.hono-adapter-amqp-vertx-66f985899f-hsk85_74894f5112a0_1-0, retrying (2147483646...