Christoph Anton Mitterer

port to Python3

3

Hey. As you've mentioned in #19 a port to Python3 will be necessary to keep `zktop` alive. I'd guess it would run mostly out of the box with Python3, given...

clientPort is deprecated

4

Hey. AFAIU, `clientPort` is deprecated,... but when one removes it, zktop fails: ``` Traceback (most recent call last): File "/usr/bin/zktop", line 11, in load_entry_point('zktop==1.0.0', 'console_scripts', 'zktop')() File "/usr/lib/python3/dist-packages/zktop.py", line 392,...

default to using the ZK server’s cfg

3

If a ZooKeeper server is installed on the system, zktop is likely expected to connected to the ZK enseble of that and not only to the local ZK server. •...

try --config=/etc/zookeeper/conf/zoo.cfg first before trying localhost:8121

3

Hey. Would be a nice feature, if zktop per default tries: --config=/etc/zookeeper/conf/zoo.cfg before it does the implicit --server localhost:8121 What people typically want is probably that they see all the...

### Proposal Hey there. (Spoiler: IMO the current `keep_firing_for` is not a proper solution for what I'm dealing with). This originates from a discussion at: https://groups.google.com/g/prometheus-users/c/Ihh1Dk0puQw The problem I have...

### Proposal Hey. When setting `keep_firing_for` for some alert rule, it would be nice if one could further select label sets for which it will actually apply. Like assume one...

major changes

4

Hey. Sorry for not splitting this up in more branches (was lazy), but at least the changes are all split up nicely in small commits. Please check them and merge...

plugin fails if media filename contains newline

1

Hey. At least for the case that the media file name contains a newline (`\n`), but possibly also for other such unusual characters (perhaps `\r`), the plugin fails, e.g.: ```...

possible security issues

7

Hey. I was reading through the code and while I'm probably no expert (never used lua before) I might have found some issues. First, we must generally assume that pathnames...

hash the file contents, not the pathname

1

I personally probably don't need this, but just as an idea: Hashing the pathname has a number of disadvantages, well mostly one,... what if the file (or an of its...