Caleb Lloyd

Results 114 comments of Caleb Lloyd

I think that Blazor WebAssembly running in the browser will use the Browser's websocket implementation, which doesn't support headers.

Potentially another piece of savings: I know it'd be a breaking API change - but do we really need `Size`? Seems like that is maybe left over from an earlier...

I guess I can see the benefits of `Size` in certain cases. But the current implementation only sets a Size on incoming messages. What about making a method that could...

> How? serialize previously deserialized message data? this is not always invertible. Yes, that's what we would have to do. True, we don't track the Deserializer (which may not even...

I guess if we take it a step further, we could also wait to call `NatsMsg.Build` until the message is read off the channel, meaning de-serialization would happen at that...

PR was opened yesterday: https://github.com/nats-io/k8s/pull/912

Released: https://github.com/nats-io/k8s/releases/tag/nats-1.2.0 Anything else to do here or we can close?

A couple more ideas, which could be done in a follow-up before releasing: 1. Do we want to nest this option under `NatsWebSocketOpts` instead of setting it directly in `NatsOpts`?...

What happens if they use MaxBytes instead? Won't the channel be 1024 again and it will pull through all of the messages until it is full again? Should we introduce...

@satyarohith need me to make any other changes to this PR?