Caleb Williams
Caleb Williams
Yikes I’ve been missing emails on this. I’ll review today and push.
@Lodin tests seem to be failing on MacOS. Code looks mostly fine but I didn't do a deep dive due to the tests. Once that's complete, I'd be happy to...
Sorry, I should have been more clear. I’m just looking for the utility classes that are available like buttons, shapes and layouts. Anything where classes are applied so I can...
Yeah, I’ll look at it. Submit a PR and make sure there’s a regression test.
Try upgrading to the latest Lit SSR. Internals should exist in that package.
Hmmm, it was there at one point and it’s in the documentation. Would be happy to field a PR adding it back in.
I can look into this but it is currently my belief that there is no way to indicate a mixin field/method as protected in TypeScript with proper intellisense support. If...
What I'm getting at is that [you can't define a property or field as protected from the context of a mixin and have TypeScript recognize it](https://www.typescriptlang.org/play?#code/KYDwDg9gTgLgBDAnmYcDCEB2BnGUCuAxjNADwAqcAvHAErCHQAmpuUAlpgOYA0c+mANaYIAd0wA+CdTiZgouAAoAdKoCGULtgBccNZkQBtALoBKatPIBuAFA3QkWHABmA4uyxwAYtAC2GTDwIABsAWXYQTlIbODhyACE1bFRQGGBMJmx0LDYiEihSAAlyUIAZAFFg4F90mGkAMjgAbzgIACNkqAA3YCYAQRg8djb8NOwAfl02Ti44EzgAXxsJRQBlfBQoNGCknTjE5PMmmNi4Qh3sLJ8ofywg4LhU9My4dc3t3eaT09OwKAg0sRenBkjAAGpqYL4YCKLqQ6FTIbcUy6LoQdhML4-bGnRg4ELAZTBCBcWHw4CmWw42JLH5Lb5wKDAGD4KCYbx+AL3PRZAK5YhkATCMSSOCNBJJYC2el43BwcIgXofS4ya63QL-MIRTiKYplSrVWqUuznT4+CCPEBpDJZBVKi5ZY4-WV4PLQRRHBk-bAbYBQD22L2nGAAC3Y2GUoIhUJhAHI2hpY8a6TYlkA). That's why we provide...
Like I said, both SkateSSR and jsdom have the ability to work with shadow DOM. Why wouldn’t those approaches work in this instance?
Following up here to make sure this doesn't become stale. Is this anywhere on the roadmap?