form-participation icon indicating copy to clipboard operation
form-participation copied to clipboard

Published 20 hours ago • verified publisher icon open-wc

formControlValidationGroup implementation missing

Open vospascal opened this issue 1 year ago • 4 comments

i saw a example using formControlValidationGroup now i checked the code and the history on formControlValidationGroup there was a pr from @calebdwilliams but i dont think there is any current implementation using formControlValidationGroup was this intentionaly?

is there a work around for this so you can validate radio input groups? if not ill see if i can help with a implemention to put it back in

it use to be added with this pr https://github.com/open-wc/form-participation/pull/12

i also see formValidationGroup still in there

vospascal avatar Dec 01 '23 00:12 vospascal

Hmmm, it was there at one point and it’s in the documentation. Would be happy to field a PR adding it back in.

calebdwilliams avatar Dec 01 '23 02:12 calebdwilliams

yea that would be great @calebdwilliams if its not to much work i think its needed to be able to validate a radio group

vospascal avatar Dec 01 '23 09:12 vospascal

i did some more digging looks like this pr removed it https://github.com/open-wc/form-participation/pull/27/files#diff-2e8511e42c76675f162dfdff43cb64c3311aa31b11174728477def4f6bde28daL366 @calebdwilliams

vospascal avatar Dec 04 '23 17:12 vospascal

@vospascal fyi, I received this info from one of the repository's code owners (when I said formControlValidationGroup was missing & I needed help for implementing radio & radio-group web components)

image

Goldflow avatar Jan 03 '24 15:01 Goldflow