Caleb Evans
Caleb Evans
> I changed two lines in dfa.py in _stringyfy_states(states) function. it was not actually made for handling integer states Ah yes, sorry about that. I made commits a while back...
@abhinavsinha-adrino Hmm, might you be able to cover that branch if you provide an empty string as a regex to your conversion method? That is, writing a test for: ```python...
@abhinavsinha-adrino I would recommend updating the validation rules to allow for a single-state machine, then. I assume the same single-state case is equally valid for DFAs, as well, correct? As...
@abhinavsinha-adrino I think you're pretty close, but there's still some missed coverage in `gnfa.py`: https://coveralls.io/builds/51282846/source?filename=automata%2Ffa%2Fgnfa.py#L237 Also, I still left you some comments to make some tweaks to the README markup....
@abhinavsinha-adrino No worries! It should be under the **Files Changed** tab at the top of the PR. Here are some screenshots of the comments I've posted:
@abhinavsinha-adrino Thanks! Also, I'd hate to add on one more thing, but it looks like the coverage has decreased ever so slightly: https://coveralls.io/builds/51359029
@abhinavsinha-adrino Yep, I'll take care of the README, and I'll post comments on the remaining items in a little bit.
@abhinavsinha-adrino So it looks like all of my outstanding comments on this PR have been resolved, and I see that you've brought the code coverage back up to 100%. So...
@tcosmo This is a great idea. @YtvwlD, do you think this is something you'd be up to tackle?
Does anyone here still have an interest in this feature? My only concern is that even if it were feasible to implement, there would be countless edge cases that could...