Caleb Evans

Results 100 comments of Caleb Evans

Great, glad to hear you feel the same. With that, I have just merged 4c95310e6929e2f9c63696b6d49dbcfc4cdd3aa8 and dcad68566e961f324b65a7eaecdf30347cb2aba7 into the `develop` branch, so I think it's fine to close this issue...

@eliotwrobson Just wanted to follow up on this PR, since it is still in **Draft** status. Are you still working on this? Or is it actually ready for my review?

@eliotwrobson Hmm, so are you saying that in order to complete this PR, you need to make breaking changes like changing the name of the subclass validation methods?

@eliotwrobson Gotcha. Whatever you can do to keep the current API / method names would be preferable, since I chose all the method names very intentionally. But let me know...

@eliotwrobson Just a heads-up: I recently merged #46 which made a bunch of changes across the codebase. I suspect you will need to redo this PR quite a bit if...

@eliotwrobson Understood, and I think I'm inclined to agree re: type hints. I feel like if you have the right tooling in place, many of the types can be inferred...

@abhinavsinha-adrino I see. Well, I am not very familiar with the math behind the Kleene Star operation (that was a user contribution to the library). But, if you would be...

@abhinavsinha-adrino Just in case you were wondering: I plan to keep this issue open until your code gets merged to `main` as part of the v6 release. 😄

@abhinavsinha-adrino Closing this issue now that Automata v6 is released with these optimizations/fixes. Thanks again for contributing these!

@lewiuberg I am open to this idea! Can you please submit a pull request with your method? Please add the relevant tests, as well.