Tong Cai

Results 4 comments of Tong Cai

@ysawa0 https://github.com/envoyproxy/ratelimit/pull/137 make redis client do pipelining more efficiently to improve throughput (by buffering as much as possible commands from concurrent requests in a time window), so it is possible...

> this would turn the feature completely off, correct? Yes, in this case, redis commands will be sent immediately

Comparing benchmark stats for no pipeline case (by run https://github.com/envoyproxy/ratelimit/blob/master/test/redis/bench_test.go#L68), I do observe cpu performance degradation. ``` benchstat /tmp/ratelimit-before-1657473a.stat /tmp/ratelimit-master.stat name old time/op new time/op delta ParallelDoLimit/no_pipeline-4 12.4µs ± 0%...

@ysawa0 can you try this to see if it can fix the problem https://github.com/envoyproxy/ratelimit/pull/163 open a new issue to track this https://github.com/envoyproxy/ratelimit/issues/164