Chao Xu

Results 22 comments of Chao Xu

> As is, the initial AddAfter call will enqueue the Deployment but it is unnecessary. Ideally it should be cancelled as soon as another invocation of AddAfter with the same...

cc @lavalamp @mbohlool @ericchiang @hongchaodeng Do you know if there is an existing tool that checks for changes in public interfaces? I couldn't find any.

The `release-note` approach relies on the author and the reviewer to identify the breaking changes. I'd rather relying on the tool to force the author to add `release-note`.

> Given that the stable API surface is smaller than all packages, Could you elaborate on what packages should be excluded from the API surface? The packages that don't have...

This issue turned out to be bigger than client-go. @lavalamp opened up https://github.com/kubernetes/test-infra/issues/3415. I'll keep this issue open until https://github.com/kubernetes/test-infra/issues/3415 has an owner. Thanks @ericchiang. That's a good start. I'll...

@lavalamp @sttts thanks for the answers. I think @lavalamp's point is that not all public interface of a vendored repo should be count as the API of client-go; and @sttts's...

cc @jennybuckley @roycaihw who might be interested in expanding the [tool](https://github.com/kubernetes/client-go/issues/234#issuecomment-314021848) Eric built.

> While all requests for an established connection should go through the same agent I'm not sure if this is true. It seems that the proxy server always sends traffic...

Thanks, @ScheererJ. The changes look good. Given the below reasons, I think we are not ready to merge this PR at the moment: * @jkh52 and the team are working...

Thanks @jpbetz. Maybe a single auger release can import schemas from multiple versions of Kubernetes, and dynamically select the schema based on a commandline flag.