C Dorn

Changing `utf8_encode()` to `encodeURIComponent()` may solve all the encoding issues. e.g. ``` javascript:alert(encodeURIComponent("Çáåøn")); javascript:alert(decodeURIComponent("%C3%87%C3%A1%C3%A5%C3%B8n")); ``` Need PHP implementation of `encodeURIComponent()`.

Generate JUnit XML

1

Would be awesome to optionally get a JUnit XML test report at the end. Any suggestions as to how that could best be accomplished?

Missing docs

3

Missing from: http://www.iab.net/media/file/SafeFramesSpec.pdf - `$sf.ext.supports().bg` - `$sf.ext.supports().pin` - `$sf.ext.geom().par`

See: https://github.com/InteractiveAdvertisingBureau/safeframe/blob/28cdb063e0776fa6b265ac4c4f47ec1ffc4d2b3a/src/js/ext/ext.js#L1477

gh-pages default branch

1

any reason why you use gh-pages as your default branch? I would use master and write a quick script that published to gh-pages. Such as: https://github.com/pinf/pinf-loader-js/blob/master/Makefile#L29-L32

I have a couple of other fixes so I thought I might submit this fix.

Use `window.addEventListener` instead of `addEventListener`

4

Having `addEventListener` dangle as a global is not ideal. Please use `window.addEventListener` to provide more context to static analysis tooling.

Visual modelling

1

What do you think about modelling the primitives involved using something like http://www.jointjs.com/api ? I envision reactive modelling systems that can present the primitives to allow users to build valid...

The `read` function from `file.read` in loader.js always comes from bootstrap.js instead of file.js. This makes it impossible to create a loader (to be passed into a sandbox) that makes...

Currently the Narwhal loaders are all based on the filesystem. A module must be in the filesystem in one of the search paths. We need to add hooks to allow...