Paul Buehne

The new commits introduce a macro for generalizing similarly structured methods. I put it together quickly and roughly, so this probably isn't the nicest it could be. Looking forward to...

That's why I deprecated rather than removing the methods outright ;) I still think that having a distinct builder and setters is an improvement because it allows for more granularity....

I removed the macros, saving a dependency (`paste`) and split the builder-like API of `Reedline` into a seperate file. Personally, I prefer the macro version, but I wouldn't reintroduce the...

(I think I did some general "tidying up" in some files alongside the actual code changes. I hope that's fine)

> and split the builder-like API of Reedline into a seperate file. The motivation for this is to 1. reduce the lines of code in `engine.rs`, which is a large...

> With how we are handling the Reedline object in nushell we can't fully go ahead with the deprecations you suggest. During each REPL iteration we in effect "mutate" certain...

If it would be fine to increase the sizes of the `Pusher` and `Popper`, the shelves could also be their struct members. This might allow better safety with the same...

There's a proposal for this for Godot too! https://github.com/godotengine/godot-proposals/issues/8906

What about adding something like a `signed_angle_between` which accepts a `bool` or `enum` for left/right-handedness or is always right/left-handed and requires consumers to flip sign accordingly? EDIT: Check out [this...

> An inline list must always end with a closing `]`, so a different closing character like `|` avoids conflict. Wouldn't this require arbitrary lookahead?