Paul Buehne

Results 32 comments of Paul Buehne

> But we haven't come around to this and it also tends to be annoying due to the time-consuming debugging process. I should have some spare time on hand in...

> We really shouldn't be using unwrap in a lot of cases. Are there places where using `unwrap` is ok with you? (The link needs updating. I counted four `unwrap()`s...

My suggestion would be to design the prompt as something like this ``` [ header ] [ before ] [ after ] [ footer ] ``` or, for multiline input...

As this now uses `before` and `after` this can easily be mirrored in the rendering step for right-to-left prompts.

I should add this is in fact similar to what is done currently. I am asking for well defined and structured behavior.

The normal `Range` works flawlessly though.

I forgot to add documentation, which I think is important, so I won't mark this PR ready without it. I might add a (declarative) macro for the Builder as well,...

> What makes these changes better or more intuitive for API consumers? I think the largest improvement is naming consistency for related methods. Names should help choose which method to...

I made some notes on what I want to improve. When I look at them now there are things that probably would have been less structural changes (like the consistent...

> We're generally against macros unless they're undeniably intuitive and necessary, with the nushell team being the judge, of course. A lot of the builder code is repetitive and a...