akrm al-hakimi comments

Results 10 comments of


                                            akrm al-hakimi

add semicolon in conditions like have text before expected text

Pull request #563

should we help users do not shoot their legs when using browser.all(selector) in for loops?

So I think this workaround actually makes sense; I'm iffy on the final block you referenced. I'm not entirely adjusted to the code base and your overarching goals yet, but...

Add support for tcsh shell

@rustbot claim

Add support for tcsh shell

Hi @rami3l, @rbtcollins- I opened #4459 I was lurking this repo looking for a potential way to contribute to one of my favorite tools of my favorite language. This is...

should we keep be._empty as 4-in-1 condition and correspondingly remove its experimental _ prefix?

I briefly reviewed the test cases, and I agree that the current polymorphic behavior could create confusion Instead of `be._empty`, we could make the API more explicit (although I know...

Lack of linker is not reported

@rustbot claim

(#523) final energy output omission correction

@LSchwiebert Ah, I see. I misunderstood this then. Before I adjust the patch maybe I can run this by you first to make sure I'm on the right track. In...

'rustup' detects inappropriate default host and incorrectly handles full paths set in _HOME environment variables

@rustbot claim

'rustup' detects inappropriate default host and incorrectly handles full paths set in _HOME environment variables

@rami3l or @djc Both of these look fixable with localized changes, but I wanted to check first: is Cygwin considered a supported environment, or more of a best-effort case? I...

fix(toolchain): improve error message for '+toolchain' prefix

> forbid toolchain names starting with `+` Does this also steer from the original issue at hand?