Carlos Alexandro Becker
Carlos Alexandro Becker
for which tld? can you also add tests for it?
.de TLD does not return any expiration times on the domains I tested at least... not much we can do...
you can test building using dockerfile.dev
also `go test -v ./...` will test it (and you can add a case specific for this problem as well)
Probably need to improve this RE https://github.com/caarlos0/domain_exporter/blob/master/internal/whois/whois.go#L52 so this happens: https://github.com/caarlos0/domain_exporter/blob/master/internal/whois/whois.go#L112-L115 GitHubcaarlos0/domain_exporterExports the expiration time of your domains as prometheus metrics. - caarlos0/domain_exporter GitHubcaarlos0/domain_exporterExports the expiration time of your domains...
maybe accept a `?whois` query param would do the trick?
this is a good one, although arguably a breaking change. If anyone wants to work on a PR for this, I would be glad to review it.
hey, thanks for opening this happy to review a pr fixing this! 🙏
I have the same issue.
ping @remyoudompheng