Adam Piasecki
Adam Piasecki
As I work on this issue I noticed that [awaitCompletion()](https://github.com/coreos/coreos-assembler/blob/7ebc623d824bb5543754c25017dac6b40d5175af/mantle/cmd/kola/testiso.go#L665) does not specify what `console` is. In this case (if my understanding is not flawed) Go automatically assigns it `false`...
> Running the tests with `--console` should set the value to true Now, that makes sense :) Merci!
Just a quick update: Some things in this PR are most likely not-recommend. 1. hardcoding the console.txt ```consoleFilePath := filepath.Join(outdir, "console.txt")``` Especially, since platform.Machine already contains [ConsoleOutput](https://github.com/coreos/coreos-assembler/blob/main/mantle/platform/platform.go#L87) Moving to `consoleFilePath...
This was discussed at Fedora community meeting yesterday. We will add a new top level contributing page to our docs.
If no one else is looking at this, I'd like to give it a go. That's actually something I was considering during my work on some of the kola testiso...
@prestist, please let me know if that's what you were after.
> @prestist, please let me know if that's what you were after. Ok, sorry for the noise. Will look at it again in the morning -> converted to draft.