Adam Piasecki
Adam Piasecki
I ran the code through the gofmt, yet it still fails the linter check. Can I get any pointers on this, please? The error description does not seem to be...
I installed the version of golangci-lint as per the pipeline. The output seems to have nothing to do with code I modified. Here's the result of golangci-lint: ``` adamsky@fedorapc Work/coreos-assembler...
> Maybe can try newer go version like 1.22, see [coreos/repo-templates#248](https://github.com/coreos/repo-templates/pull/248) and [coreos/repo-templates#249](https://github.com/coreos/repo-templates/pull/249) (as 1.21 is EOL) I tried it and it didn't help: ``` adamsky@fedorapc Work/coreos-assembler (PR/badness_1) » golangci-lint...
Thank you @dustymabe for the last update.
If it's not pressing, I would love to look into this when I'm done with the issues I am currently working on.
> @c4rt0 folding testiso into regular tests is on my radar let's collab on this if you want ! Great idea, I'd appreciate that.
I have a question. In kola/testiso.go we have [the result](https://github.com/coreos/coreos-assembler/blob/main/mantle/cmd/kola/testiso.go#L636-L641) which simply checks if there was an error while writing test results to `output`. Going further, the reporter sends FAIL...
> Specifically what we want is two bits from kola: > > 1. calling [`CheckConsole()`](https://github.com/coreos/coreos-assembler/blob/7ebc623d824bb5543754c25017dac6b40d5175af/mantle/kola/harness.go#L1920-L1953) on the console output. I feel like the above is now covered with [this PR](https://github.com/coreos/coreos-assembler/pull/3895)....
Awesome, thank you.
> I'd say let's not worry about this for now and we'll get the checkMachine bits when (if) we fold testiso into the regular kola tests. > > We can...