c3c
c3c
Should be implemented with latest commits. Make sure to re-run pip as dependency versions have changed.
Ah forgot to stage that line for the main branch. https://github.com/c3c/ADExplorerSnapshot.py/commit/38e5100ee5925e1adfe63591f9df7fb97d35ca5e
thanks for making this change, closing it in favour of #16
Thanks for the PR! Before I accept, we should add a minimum version requirement for bloodhound in the setup.py, do you want to add that? ________________________________ From: Julien EGLOFF ***@***.***>...
Gracias :)
I'm wondering if this is still needed? I think the issue might've been resolved with https://github.com/c3c/ADExplorerSnapshot.py/issues/38 Nonetheless, might still be useful to have it in Docker.
Thanks for reporting! @PTVB have you run into this before? May also be related to this line that is commented out atm https://github.com/c3c/ADExplorerSnapshot.py/blob/main/adexpsnapshot/__init__.py#L1063
looks like it is attempting to parse an ADSTYPE that isn't supported. Could you patch the following lines (189-190) to read "self.snap.log" instead? I'm not sure/can't remember from the top...
Initial support being implemented in feature branch: https://github.com/c3c/ADExplorerSnapshot.py/tree/feature/ous-gpos-containers Requires a preprocessor pass to construct a tree for child objects.
In general i think making it more generic to allow different parsers is a great idea. Will merge after I’ve implemented tox tests.