ADExplorerSnapshot.py icon indicating copy to clipboard operation
ADExplorerSnapshot.py copied to clipboard

Fix issue #38

Open laxa opened this issue 1 year ago • 4 comments
trafficstars

This small commit fixes issue #38 when installing current sources.

laxa avatar Dec 18 '23 17:12 laxa

Thanks for the PR! Before I accept, we should add a minimum version requirement for bloodhound in the setup.py, do you want to add that?


From: Julien EGLOFF @.> Sent: Monday, December 18, 2023 6:19:27 PM To: c3c/ADExplorerSnapshot.py @.> Cc: Subscribed @.***> Subject: [c3c/ADExplorerSnapshot.py] Fix issue #38 (PR #39)

This small commit fixes issue #38https://github.com/c3c/ADExplorerSnapshot.py/issues/38 when installing current sources.


You can view, comment on, or merge this pull request online at:

https://github.com/c3c/ADExplorerSnapshot.py/pull/39

Commit Summary

File Changes

(1 filehttps://github.com/c3c/ADExplorerSnapshot.py/pull/39/files)

Patch Links:

  • https://github.com/c3c/ADExplorerSnapshot.py/pull/39.patch
  • https://github.com/c3c/ADExplorerSnapshot.py/pull/39.diff

— Reply to this email directly, view it on GitHubhttps://github.com/c3c/ADExplorerSnapshot.py/pull/39, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AARYDIO25AA2WESOXQHV5ZTYKB3J7AVCNFSM6AAAAABAZ3WFDCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2DOMJRGAZTENY. You are receiving this because you are subscribed to this thread.Message ID: @.***>

c3c avatar Dec 18 '23 17:12 c3c

I updated the PR to require at least the 1.7.0 version where this change was introduced in bloodhound.py.

laxa avatar Dec 18 '23 18:12 laxa

note that this PR is no longer needed since I've removed the extra parameter which broke this in bloodhound.py 1.7.2

dirkjanm avatar Dec 21 '23 12:12 dirkjanm

I updated the PR to only require version 1.7.2 then.

laxa avatar Dec 21 '23 12:12 laxa

Gracias :)

c3c avatar Feb 25 '24 16:02 c3c