chielP

Results 14 comments of chielP

I added a check which requires the type to be string / enum or categorical otherwise the comparison will return a `ComputeError`

There seems to be bug related to equality check for the underlying categories. It is not exhaustive at the moment

@swapdewalkar ,Yes go for it!

Love this! For me the code ran, but lldb gave an error at the end. In order for it to work I had to disable [ptrace protection](https://linux-audit.com/protect-ptrace-processes-kernel-yama-ptrace_scope/) like was mentioned...

I also got it to work on CLion following this guide: https://www.jetbrains.com/help/clion/debugging-python-extensions.html#debug-custom-py. You can either go for option 1, but that will get annoying fast. If you follow option 2...

Any integer up to U32 yes since we could simply cast, however not U64. Our Categorical Type uses fixed U32 for indices. There is an open issue to change this,...

Aah misunderstanding, I thought you meant that the indices were going to be U64. But simply casting we can

Decimals comparisons are not implemented yet, also without NULLS. This also raises ``` x = pl.Series([1],dtype=pl.Decimal) x.equals(x) ```

https://github.com/pola-rs/polars/blob/f93e4505157905ea159054ce9a8e2cf091acb823/crates/polars-core/src/datatypes/dtype.rs#L76 The problem of equality check is here. We need to distinguish Enum from Categorical. Right now, if you do `df.select(pl.col(Enum))` or `df.select(pl.col(Categorical)` you get both categorical and enum columns....