before_after icon indicating copy to clipboard operation
before_after copied to clipboard

before-after 1.0.1 has requirement mock==1.0.1, but you'll have mock 3.0.5 which is incompatible.

Open Rogalek opened this issue 5 years ago • 5 comments

Will you work with that project more or it is dead?

Rogalek avatar Sep 02 '19 14:09 Rogalek

Hi Rogalek,

Given it's a fairly small library there's not much active work, but I merge in any PRs for issues that come up - can you clarify what the issue is that you're experiencing?

I can certainly change the requirements to use a more recent version of mock, but I haven't tested for compatability with new versions of mock (though the library is unit tested).

Are able to try the upgrade you're suggesting and see if the test suite still passes?

Christy

c-oreills avatar Sep 02 '19 15:09 c-oreills

Ok, I will try and tell you results.

Rogalek avatar Sep 03 '19 13:09 Rogalek

I updated your tests to work with python3 print and mock3 and try your test suite.

============================================================================== test session starts ==============================================================================
platform linux -- Python 3.7.3, pytest-5.1.2, py-1.8.0, pluggy-0.12.0
rootdir: /home/rogal/PycharmProjects/before_after
collected 7 items                                                                                                                                                               

before_after/tests/test_before_after.py .......                                                                                                                           [100%]

=============================================================================== 7 passed in 0.04s ===============================================================================

It should work and I have made you pull request. Is it working with python3 now?

Rogalek avatar Sep 04 '19 14:09 Rogalek

@c-oreills what do you think?

Rogalek avatar Sep 13 '19 07:09 Rogalek

With http://pyfound.blogspot.com/2020/03/new-pip-resolver-to-roll-out-this-year.html around the corner, not upgrading to mock version >=2.0.0 can break stuff for a lot of projects.

pgAdmin avatar Sep 17 '20 09:09 pgAdmin