Colin Flaherty comments

Results 9 comments of


                                            Colin Flaherty

Early stopping and finetuned optimizer state

@lightvector Note for later: Turning these flags on may break requeue-ability (because lr scheduler state is destroyed on job initialization). We need to look into that before merging this

Issue downloading nonsense_ensemble (fix)

What specifically was the bug (log paste would be helpful), and what line-by-line change fixed it?

Error when install postman

Closing since it sounds like @WilliamsToTo identified loading cuDNN as fix for first bug, and @rkulskis found a solution to the second bug involving setuptools version. Thank you both!

Undefined names in Python code

I see that the rollout.py variable names are defined right above this function. I think we can fix by using `nonlocal` on these so flake8 knows where to look?

Undefined names in Python code

> Where is 'FROZEN_SYM_BD' supposed to be declared? See @lightvector 's comment in https://github.com/facebookresearch/diplomacy_cicero/issues/20.

Update download_model_files.sh

Thanks @shobith !

E NameError: name 'FROZEN_SYM_BD' is not defined

Quick note: Since you mentioned MacOS, my guess is you don't have an NVIDIA GPU and hence no CUDA, which is required for this repo. We're using Ubuntu 20.04.4 LTS,...

E NameError: name 'FROZEN_SYM_BD' is not defined

What's MPS?

Did you run `make` first? See comment here for info on FROZEN_SYM_BD: https://github.com/facebookresearch/diplomacy_cicero/issues/20. It's by autogenerated code generated by `make`. You shouldn't have to add an `google.protobuf.message` import anywhere. I...