Christopher Ehrlich

Results 130 comments of Christopher Ehrlich

Yeah, we're absolutely requiring review on every PR. Every good author and journalist has an editor etc. I appreciate that this delays the release, but there are no exceptions to...

> I think the icons should be flipped in RTL > > from ![Screenshot_3](https://user-images.githubusercontent.com/79310652/205899698-533e5263-43af-499d-a937-96908ca57947.png) > > to ![Screenshot_4](https://user-images.githubusercontent.com/79310652/205900912-5f3ed3a1-6c32-44a5-badf-805d8a9849a0.png) good catch, will open a separate issue for this

Lets go 🎉

I think recommending (or maybe even requiring) a specific node version could be a good idea for the scaffolded app. In the CLI on the other hand I think we...

> > > Would it maybe make sense to instead of using an nvmrc (we already have a lot of root level files) to use engines and possibly also engineStrict...

After looking at the options that nvmrc allows, the most sensible choice to me seems like either `lts/*`or not creating the file at all. What does everyone else think?

> > After looking at the options that nvmrc allows, the most sensible choice to me seems like either `lts/*`or not creating the file at all. What does everyone else...

It seems our twitter api token has expired or become invalidated. We need to either update it, or just hardcode/"fake" the tweets.

Astro has this, which seems to work quite well: https://github.com/withastro/docs/issues/438 They also have a great translation team/process in general. Will take a look at it this week to see what...

Are you describing something like this? I like this idea a lot. The only possible downside I can see is additional complexity in maintaining the page, but hopefully there's a...