create-t3-app
create-t3-app copied to clipboard
docs: arabic translation
Changelog
Changelog
-
[x] Arabic translation Done
- [x] deployment
- [x] docker.md
- [x] vercel.md
- [x] usage
- [x] env-variables.md
- [x] first-steps.md
- [x] next-auth.md
- [x] next-js.md
- [x] prisma.md
- [x] tailwind.md
- [x] trpc.md
- [x] typescript.md
- [x] faq.md
- [x] folder-structure.md
- [x] installation.md
- [x] introduction.md
- [x] other-specs.md
- [x] t3-collection.md
- [x] why.md
- [x] deployment
-
[x] Rephrasing (Done)
- [x] deployment (Done fixing errors and Rephrasing)
- [x] docker.md (Done fixing errors and Rephrasing)
- [x] vercel.md (Done fixing errors and Rephrasing)
- [x] usage (Done fixing errors and Rephrasing)
- [x] env-variables.md (Done fixing errors and Rephrasing)
- [x] first-steps.md (Done fixing errors and Rephrasing)
- [x] next-auth.md (Done fixing errors and Rephrasing)
- [x] next-js.md (Done fixing errors and Rephrasing)
- [x] prisma.md (Done fixing errors and Rephrasing)
- [x] tailwind.md (Done fixing errors and Rephrasing)
- [x] trpc.md (Done fixing errors and Rephrasing)
- [x] typescript.md (Done fixing errors and Rephrasing)
- [x] faq.md (Done fixing errors and Rephrasing)
- [x] folder-structure.md (Done fixing errors and Rephrasing)
- [x] installation.md (Done fixing errors and Rephrasing)
- [x] introduction.md (Done fixing errors and Rephrasing)
- [x] other-specs.md (Done fixing errors and Rephrasing)
- [x] t3-collection.md (Done fixing errors and Rephrasing)
- [x] why.md (Done fixing errors and Rephrasing)
- [x] deployment (Done fixing errors and Rephrasing)
⚠️ No Changeset found
Latest commit: de7baa9e4ea6e0174582e6bd5f18cb7dcac7a8a0
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
create-t3-app | ✅ Ready (Inspect) | Visit Preview | Dec 8, 2022 at 1:35PM (UTC) |
⚡️ Lighthouse report for the changes in this PR:
Category | Score |
---|---|
🟠 Performance | 68 |
🟢 Accessibility | 100 |
🟢 Best practices | 100 |
🟠 SEO | 86 |
🟠 PWA | 54 |
Lighthouse ran on https://create-t3-app-git-fork-a4addel-next-t3-oss.vercel.app/
@a4addel is attempting to deploy a commit to the t3-oss Team on Vercel.
A member of the Team first needs to authorize it.
Your filenames shouldn't include .rtl, that messes up the url
Your filenames shouldn't include .rtl, that messes up the url
It's for vscode to be able to translate more comfortably and not meant to reach production
Your filenames shouldn't include .rtl, that messes up the url
It's for vscode to be able to translate more comfortably and not meant to reach production
Interesting, I'd imagine plugins like that would be able to read the frontmatter?
Your filenames shouldn't include .rtl, that messes up the url
It's for vscode to be able to translate more comfortably and not meant to reach production
Interesting, I'd imagine plugins like that would be able to read the frontmatter?
Exactly it's called RTL Markdown
Your filenames shouldn't include .rtl, that messes up the url
It's for vscode to be able to translate more comfortably and not meant to reach production
Interesting, I'd imagine plugins like that would be able to read the frontmatter?
Exactly it's called
RTL Markdown
So does it parse correctly if you rename the file but keep the frontmatter? Just curious
So does it parse correctly if you rename the file but keep the frontmatter? Just curious
I was too And found out that the vscode editor is Just Regular HTML, so the plugins checks if the file opened ends with rtl.md
and dir:rtl
to the HTML tag
So does it parse correctly if you rename the file but keep the frontmatter? Just curious
I was too, And found out that vscode editor is Just Regular HTML, so the plugins checks if the file open ends with
rtl.md
and anddir:rtl
ti the HTML tag
Aaah shame it needs both, cause setting the dir: rtl
in frontmatter changes the output HTML to be rtl
btw, this is how it looks right now, imo very weird.
is it only the content, i.e. the actual doc-part that should be rtl or is it correct as it is now?
https://create-t3-app-git-fork-a4addel-next-t3-oss.vercel.app/ar/faq.rtl
btw, this is how it looks right now, imo very weird.
is it only the content, i.e. the actual doc-part that should be rtl or is it correct as it is now?
https://create-t3-app-git-fork-a4addel-next-t3-oss.vercel.app/ar/faq.rtl
It's the font, It is made for languages written in Latin script, that why it looks ugly in Arabic, I would like to use the font on this page Here, It looks so elegant
Resolve conflicts please
Resolve conflicts please 👍🏼
Resolve conflicts please 👍🏼
I think you got a bad merge cause a lot of old changes got pulled in
I think you got a bad merge cause a lot of old changes got pulled in
I forgot to Sync the repo. check it now.
Great. Just needs some ✅ reviews now
Great. Just needs some ✅ reviews now
what kind of reviews ? Linguistic review ?
Great. Just needs some ✅ reviews now
what kind of reviews ? Linguistic review ?
Refer: https://github.com/t3-oss/create-t3-app/blob/next/www/TRANSLATIONS.md#reviewing
The translation I made was 2 phases, translation
and revision
I'm sure I didn't leave behind that require someone to review it.
The translation I made was 2 phases,
translation
andrevision
I'm sure I didn't leave behind that require someone to review it.
All translation PRs require an external review. Not discounting your linguistics skills, it's just a requirement.
Yeah, we're absolutely requiring review on every PR. Every good author and journalist has an editor etc.
I appreciate that this delays the release, but there are no exceptions to this.
LGM
I think the icons should be flipped in RTL
from
to
I think the icons should be flipped in RTL
from
to
good catch, will open a separate issue for this
I think the icons should be flipped in RTL from
to
good catch, will open a separate issue for this
rtl:rotate-180
;)
EDIT: nvm that didn't work :(
Lets go 🎉