bzuidgeest

Results 12 comments of bzuidgeest

Thanks for looking into this issue. From what I can find: > In drafts 06 and 07 $defs keyword was named definitions, this has changed starting with draft 2019-09. Don’t...

This has been asked before in #1347. Since I wanted Support for System.Text.Json to I typed some code that should add this. my fork https://github.com/bzuidgeest/quicktype/tree/SystemTextJson and the PR https://github.com/quicktype/quicktype/pull/1997 If...

I got quicktype running with the code from the PR, seems to work fine as is for at least my needs. Is there any progress as to getting this included?

> @bzuidgeest You might consider use my version of quicktype. > > Source: https://github.com/doggy8088/quicktype/tree/CSharp-SystemTextJson > > npm: [@willh/quicktype](https://www.npmjs.com/package/@willh/quicktype) I already made a version for myself based on your code. much...

> It because `JsonStringEnumConverter` doesn't fit my need on certain circumstance. That much was obvious. But not very helpfull. I do know it has an "issue" arround nullable enums, but...

@doggy8088 That seems like an excellent reason for doing it the way you did. The use case is rather specifc however (I think) and I don't know if it would...

@dylanvdmerwe Replace is a bad option. A lot of people have invested in the code as-is and rely on it. Also JSON.net is far from dead. It might fade eventually,...

I took the code from the repo of @doggy8088 and merged it with the current version of quicktype using the kotlin generator as an example of how to implement selecting...

So I committed number of changes and as far as I can determine most tests run fine. Even some that are excluded with newtonsoft lib because of framework issues. Seems...

> Why is this not a thing yet? .net 6 does not even have newtonsoft That is nonsense, Newtonsoft Json.net library always has been a sperate lib and is very...