Boris Zbarsky

Results 364 comments of Boris Zbarsky

Have CommissioneeDeviceProxy return node info to DeviceCommissioner on session establishment

See also https://github.com/project-chip/connectedhomeip/pull/16224#discussion_r827248681

[BUG][Darwin][iOS] should not add a bdx:// prefiex to a ota download url when it uses vendor specific protocol.

@carol-apple

Fix ByteSpan overload of `TLVReader::Get` to only permit reading byte strings

We have such a dedicated method already on, the contiguous buffer reader. On the non-contiguous-buffer reader, the method can't be safely implemented, because the string may span buffers. The right...

Sort out what to do about emberGetCurrentNetwork

Still an issue.

PayloadHeader does not have a single source of truth for "is this an ack?" state

This is still an issue, though mAckId is now named `mAckMessageCounter`.

Note, though, that except for proxies the Node id can (and should!) be omitted.

Note that proxies are out of scope for 1.0, so we should simply not have the node id bits here at all.

Implicit conversions that lose precision should be compile errors

OK, I'm going to split this up into pieces and do part of the tree at a time, because otherwise the diff will be huge and things will bitrot... Once...

DeviceControllerFactory::InitSystemState leaks on errors

Also, none of the `Platform::New` results are null-checked.

Darwin builds both standalone and mac_gcc in CI, duplicating work

Linux has the same thing between the "Build" and "Linux Standalone" jobs...

Clarify the message context life cycle management

The important part is that we're inside `OnMessageReceived` here, right? So yes, given that the exchange will close itself unless we send a message expecting a response or claim that...