connectedhomeip icon indicating copy to clipboard operation
connectedhomeip copied to clipboard

Published 20 hours ago • verified publisher icon project-chip

DeviceControllerFactory::InitSystemState leaks on errors

Open bzbarsky-apple opened this issue 2 years ago • 2 comments

Problem

There's a lot of Platform::New followed by ReturnErrorOnFailure going on here.

Proposed Solution

Probably the DeviceControllerSystemStateParams should hold Platform::UniquePtr for a bunch of these things, but also cleaning them up properly involves Shutdown calls and whatnot....

bzbarsky-apple avatar Mar 15 '22 16:03 bzbarsky-apple

Also, none of the Platform::New results are null-checked.

bzbarsky-apple avatar Mar 15 '22 16:03 bzbarsky-apple

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Sep 15 '22 17:09 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Mar 23 '23 00:03 stale[bot]

This stale issue has been automatically closed. Thank you for your contributions.

stale[bot] avatar Apr 02 '23 05:04 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Oct 15 '23 05:10 stale[bot]