Martin Packman

Results 17 comments of Martin Packman

Same issue if applying any filters, the client-side history updating isn't preserving `/share` and that breaks the link.

The `pathname` of the `` components are wrong: https://github.com/plausible/analytics/blob/c95d37583952cbad2e25c2cf9dda9a7b20b155f6/assets/js/dashboard/stats/more-link.js#L9 https://github.com/plausible/analytics/blob/6e997e7e5d35647a750ed27290edd4dd800d6255/assets/js/dashboard/filters.js#L93 Either need a bit passed in to represent share/not-share and include that, or have another abstraction that can correctly generate...

I have reproduced this in our deployment, issue is not related to calling report directly, but comes from `stacktrace-gps` producing invalid function names. Example response: ```json { "error": { "code":...

Thank you very much for review and landing so far! Will put the next batch up for consideration later. Main things to resolve are what specifically `report()` should resolve and...

@steren Thanks! Will update our code to use latest version and some of the new interfaces.

See upstream merge proposal https://github.com/stacktracejs/stacktrace-gps/pull/57 which may not be the right fix, but is this issue. In short, your source map is not valid JSON for some reason. Probably the...

That's fair enough, and see https://github.com/GoogleCloudPlatform/stackdriver-errors-js/issues/4 for supporting private sourcemaps. If you're scrubbing sourcemaps for prod deploy though, you should also scrub the url reference from the bottom of the...

Looks like the modern Angular way is implementing the `ErrorHandler` interface: https://angular.io/api/core/ErrorHandler So, not that dissimilar from what's documented for the original Angular, but likely worth spelling out in the...

@adrienverge I think the right thing on non-unicode encodings from a user perspective is add a new error type but otherwise parse as well as possible. Could implement that either...

@adrienverge Hmm, annoying, though your suggested work around should be okay for old linux platforms without a sensible encoding set still. Four options on fixing: 1) Revert change, breaking Python...