Seif Soliman
Seif Soliman
> How about we extract the width modifying parts of `updatePosition` into a separate function, and call that in the `show` function, before `updatePosition`? I completely agree with @NadAlaba's analysis...
> Can you check now? We made some changes that hopefully will improve performance. Hi @Miodec , A day ago I managed to reproduce the issue, but in a slightly...
hey @fehmer thanks and yah very nice , just don't we forget to update the setting description too. or you think the aria-label enough ?
also didn't we still need to add a file size check before storing?
> > Isn't this done in [#6207](https://github.com/monkeytypegame/monkeytype/pull/6207)? > > Backend is not using `parseJsonWithSchema` yet been a while, should I give it a try?
> [@byseif21](https://github.com/byseif21) broo I already finished 😅 Oh shit, my bad! 😅 I thought you kinda had enough after the Frontend and won’t tackle this. I even checked the repos...
handled in #6666
> This change will cause multiple calls to `refreshCustomButtons` / `refreshPresetButtons` on first load. This needs to be done another way. hey mio check this approach and tell me what...
> How about calling `fillPresetButtons` and `fillCustomButtons` in `Settings.fillSettingsPage`, then calling `updateActiveButton` in `Settings.update`? I did it thinking it would be the best we could do here, but then I...
> Looking at the diff, this PR looks like it contains significant errors. There are many changes which I recognize as deleting real English words. > > Examples: > >...