monkeytype icon indicating copy to clipboard operation
monkeytype copied to clipboard

feat: allow user to use local file as background (@fehmer, @byseif21)

Open fehmer opened this issue 6 months ago • 5 comments

Allow the user to use a local file as custom background without uploading it to the server.

Based on @byseif21 work in #6630, thanks!

fehmer avatar Jun 25 '25 16:06 fehmer

hey @fehmer thanks and yah very nice , just don't we forget to update the setting description too. or you think the aria-label enough ?

byseif21 avatar Jun 25 '25 17:06 byseif21

also didn't we still need to add a file size check before storing?

byseif21 avatar Jun 25 '25 17:06 byseif21

hi @byseif21 , thanks for your comments. I updated the description and icon to match the same as "open file" in custom text settings. An upload icon might be confusing.

I don't think we need a file size check, the limit for idb is like 20gig or 10% of the users disc space, so we should be fine.

fehmer avatar Jun 25 '25 17:06 fehmer

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

github-actions[bot] avatar Jun 26 '25 23:06 github-actions[bot]

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

github-actions[bot] avatar Jun 27 '25 00:06 github-actions[bot]

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

github-actions[bot] avatar Jul 27 '25 18:07 github-actions[bot]

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

github-actions[bot] avatar Jul 27 '25 18:07 github-actions[bot]