Ben Wittenberg comments

Results 10 comments of


                                            Ben Wittenberg

Missing documentation for the useProfiler hook

Any plans to update the `useProfiler` hook? I'd prefer to use it instead of the HOC.

ResizeObserver loop limit exceeded

Thanks for the library @d6u! We are using the hack suggested above to workaround the issue.

SelectPanel2 Optimization: Do not add and remove keydown listener for escape key on every render

If the maintainers are interested, I fixed this issue locally. When I tried the push the branch, permission was denied. I'm not sure if you are open to contributions or...

Alphanumeric sorting initial sort

~~Hello! I was interested in contributing to Primer and I have a fix for this issue on a local branch. It seems like I might need permission to push a...

Alphanumeric sorting initial sort

👋 @joshblack , I see you reviewed a previous PR related to this issue so I wanted to let you know that I attempted to fix with https://github.com/primer/react/pull/4602.

fix(DataTable): sort table on initial render with `initialSortColumn` or `initialSortDirection` props

@TylerJDev , thanks for the review! I'm happy to implement your suggestion, but wanted to provide some thoughts for you to consider. Please let me know which option you prefer,...

fix(DataTable): sort table on initial render with `initialSortColumn` or `initialSortDirection` props

Sounds good @TylerJDev !

fix(DataTable): sort table on initial render with `initialSortColumn` or `initialSortDirection` props

Thanks for the response @TylerJDev ! This is on my radar to fix!

fix(DataTable): sort table on initial render with `initialSortColumn` or `initialSortDirection` props

Hello @TylerJDev! Sorry for the long lapse in my communication. I decided to use some time for open source earlier this year, and then I started a new job right...

fix(SelectPanel2): only bind keydown event when necessary

Hello @broccolinisoup! Appreciate the 👀. If you'd like to see any changes, I'm happy to make revisions.