Brian Wilkerson

Results 522 comments of Brian Wilkerson

While I agree that this is a false positive, the problem is that we can't reliably prevent it. - We could (as in, we don't currently but theoretically could) deduce...

I believe that the current criteria is that we don't lint if the arguments can't be constants, but do lint if they could be.

I agree that the results of type inference can sometimes be difficult for a human reader to predict, and that this can significantly impact the user experience. And I agree...

I'm not sure that a lint rule is the appropriate way to support this, but it's definitely an interesting feature request. I think what you're suggesting essentially amounts to -...

Consider adding the docs to `test_reflective_loader` and referencing them from here (and from `analyzer` and `analysis_server` and any other package that uses that support).

In an offline conversation we think that it might be related to some cached values in the Workspace / WorkspacePackage classes that isn't getting flushed when the `pubspec.yaml` file has...

Are the future edits putting the file content back to the original state, by chance?

@eernstg If we add `const` before `Xyz` the analyzer reports: ``` error: A value of type 'Abc' can't be assigned to a parameter of type 'int Function()' in a const...

The current rule says > When a `BuildContext` is used from a `StatefulWidget`, the `mounted` property must be checked after an asynchronous gap. Does the same apply for `WidgetRef`, or...