Brian Wilkerson

Results 486 comments of Brian Wilkerson

Lasse is right, this would only be a partial solution, and as such I'm somewhat disinclined to add it. We've talked in the past about using annotations for this purpose....

I disagree. The `invariant_booleans` diagnostic is a lint because it has false positives, but it doesn't appear to me that this can. This seems much more akin to the kind...

I think that would work for expressions that are or could be constants, but it would have to be applied to the operands of the `&&` and `||` operators, not...

Not to digress too far, but yes. We _might_ be able to eliminate a lot of the complexity by evaluating the expressions. It wouldn't cover all the cases, but it...

See https://www.jetbrains.com/help/idea/extract-parameter.html.

> Could we have an annotation that a parameter must be used in the implementation? That's certainly feasible, though it seems like a lot of work to annotate every parameter....

The fix appears to not work when one of the lines following the `/**` is not indented as expected. I also don't see a fix offered for either of the...

That's probably reasonable. The only place I can think of where the annotation can be used that `Never` can't be used is on a setter, but it seems highly unlikely...

Deprecating it sounds reasonable to me. I can't think of any value it has in a null-safe world.