Brandon Wees

Results 63 comments of Brandon Wees

Does not seem like the default values in Watch.py are being used as default. Do I need to add a default value to the watch creation API to set these...

Ok so I have isolated where the filters are being turned off for some reason during the `test_block_while_text_present.py` test. The lines that are updating the data store is here https://github.com/dgtlmoon/changedetection.io/blob/ebb8b8862115c8eb8f9ab5206463a80a414f8677/changedetectionio/__init__.py#L619...

Ok so I am getting frustrated with test system. I have all of my tests working on my computer (look at picture below for proof!, FYI the JSON failing to...

> I have implemented a fix in the commit above but I'm not sure if I should be touching this part. Am I missing something? I have found that there...

@dgtlmoon I believe that I have fixed all of the issues with this feature, implemented tests that actually pass consistently, and haven't broken anything test wise (hopefully 😅). Sorry for...

Correct. If you point me to the specific area where notifications are decided to be sent, I can write this feature and make a PR

What tab do you think this should go under? I was thinking Filters and Triggers? Should it only filter notifications or should it filter the actual detection? I think that...

This is my current UI, going to work on the backend now...

While I would like to have used checkboxes, there is a fundamental flaw in the way checkboxes work that will lead to a ton of changes under the hood of...

Any update on these changes? I feel that the best way to solve this is to set up something in the test framework that sets the 2 options to true...