Brandon Wees

Results 63 comments of Brandon Wees

I just ran the tests from your master branch on a Raspberry Pi. I am getting identical errors so I don't think its my code that is broken?

Just rolled back to a [previous commit](https://github.com/dgtlmoon/changedetection.io/commit/46cb5cff66805c0eef184b56706995caaf1de7b8) of yours that had checks passing and I am still getting the same errors. Could it be an update to a library that...

Note: This is all on the master branch of dgtlmoon/changedetection.io So I fount this [issue for pytest-flask](https://github.com/pytest-dev/pytest-flask/issues/140) and I rolled my own version back to 1.1.0 as suggested by the...

Ok the above error is because I was not using the test run script but after switching back to 1.1.0 the test errors go away. My test is failing so...

I have no idea what the issue was 🤷. Tests are running correctly now!

I am still fixing up my test. Will be coming shortly. Should I plan to switch to self.history or keep the `previous_text`? I do not think this feature will work...

You are only saving the most recent history (via save_history_text in Watch.py) if there is a trigger. This feature filters out the *trigger* and not the notification. Thus by filtering...

Ok perfect. Do you see any reason why `test_block_while_text_present` is failing?

Am I thinking of assertions wrong? I though that `assert b'unviewed' in ...` means that it will error out when unviewed is not found? So it is showing up as...

Am I right in setting the default settings to True in Watch.py with the below code? ``` 'trigger_on_add': True, # Allow a trigger if there are additions from the last...