Buyaa Namnan

Results 37 comments of Buyaa Namnan

CI test failures on `Microsoft.CSharp.RuntimeBinder.Tests`, `System.Dynamic.Runtime.Tests`, `System.Composition.Convention.Tests` etc could be related, I can repro locally and seems not reproduceable in other branch, looking

Comparing `RuntimeMethodInfo` handles for equality causing the CI test failures in above projects, reverted that

> Do you understand why? Have you been able to create a small standalone repro using just the reflection APIs? No, I could not understood why, a typical failure log...

Another log ```log System.Text.Tests.EncodingTests.GetEncoding_FromProvider_ByCodePage_WithDisallowedEncoding_Throws(encodingName: "utf-7", codePage: 65000) [FAIL] System.ArgumentException : ParameterExpression of type 'System.Text.EncodingProvider' cannot be used for delegate parameter of type 'System.Reflection.Binder' Stack Trace: D:\dotnet\pr2\src\libraries\System.Linq.Expressions\src\System\Linq\Expressions\LambdaExpression.cs(954,0): at System.Linq.Expressions.Expression.ValidateLambdaArgs(Type delegateType, Expres...

> @buyaa-n I have pushed a commit with a bunch of perf tweaks and simplifications. The commit description has the details. Let me know if it looks good to you...

Failures unrelated and known issue, merging

Failures unrelated, one of the failures related to [nuget package availability](https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-73520-merge-60ab0a44bdb140c1b6/System.Text.RegularExpressions.Tests/1/console.2b30313a.log?helixlogtype=result), filed an [issue](https://github.com/dotnet/runtime/issues/73854) for other

> We'd need to decide on the behavior, though. Should we treat T& as a "scalar" type like we do Nullable or as a compound type with an element like...

If we treat them as compound type and put their nullability info in `info.ElementType` what would the `info.ReadState` `infor.WriteState` would express? Further how many users would know they need to...

> @smdn I agree that perhaps differentiating between n/a and unknown in the API would be helpful, but only if it were applied universally and not just in this one...