Roman Schmid

Results 84 comments of Roman Schmid

Is this fix released somewhere? I have the following installed and run into this problem: ``` pgloader version "3.6.2" compiled with SBCL 2.0.10 ```

I think the Firstname and Lastname should be added everywhere where you add an Address (eg. Shipping and Billing Address). If there's a logged in Member, we can simply use...

You can write your own Modifier for that. I guess you'd have to add some sort of `Type` field to a product to determine whether or not tax (or which...

I don't think you need to rely on the `$incoming` value. Just ignore it and calculate tax based on order contents (accessible via `$this->Order()`)

That module you linked to doesn't do things differently than I suggested. It doesn't take discounts into consideration either… The architecture with Order-Modifiers only works well for certain scenarios. Ideally,...

I'm reopening this, so that this discussion isn't getting lost and can be considered when there are architectural changes about to happen. @asecondwill You might still be able to make...

Thanks for raising this. These are all important problems which should be solved. A PR would be really appreciated! And if we'd end up with some Unit-Tests that help identifying...

Are you sure the user gets redirected to the account page? This should only happen, if there's a user that's logged in: https://github.com/silvershop/silvershop-core/blob/master/src/Model/Order.php#L522 After you finish an order, can you...

Thanks for reporting this. Sadly, there's currently no easy way to solve this, because: - Checkout-steps aren't getting validated properly (eg. validate that each checkout-step has been passed). - Adding...

Some work went into #640, so that it doesn't look completely broken. The layout could be much better though and it doesn't work well on mobile.