Patrick

Results 90 comments of Patrick

Good work :+1: but there are two things: first you should request a merge to bumbummen99/LaravelShoppingcart instead of Crisane's repository. Also you will have to rename the translated Readme.md to...

Just noticed that you wrote indonesian, i really should not do reviews that late :laughing:

I highly doubt this will be merged as you have modified the package name. Also please make sure the phpunit tests are still working.

7.2 is EOL anyways, it might be good to remove it: https://www.php.net/supported-versions.php

"phpass was released in 2005 when a typical web host ran PHP 4 and a typical web app used raw MD5. In 2007 and on major web apps moved to...

Just add an key for auth or check the request ip to a known one. When you do decide you create your own API request then it is also up...

https://www.php.net/manual/en/configuration.file.php#example-36

This is a blocker for my project

The package has been built to store the cart in the session. I have already stated somewhere else that i want to further abstract the storage location to be more...

I would love to see this feature in js-beautify as well as VS Code HTML formatter.