Bugsounet - Cédric

Results 63 comments of Bugsounet - Cédric

@rejas but in this case if we use `MODULE_DOM_CREATED`, i'm not sure that `Module.definitions` is set correctly we have to check around this

mistake: it's `request` ... not `moment` ;)

Ah yes, I forget this, sorry `luxon` will help :)

Can I close this PR ?

will not be implemented

> adding the compliments to the MagicMirror/config/config.js file didn't override the default compliments. Tested with new compliments in config.js, it's works I think you have made an error in your...

# Configuration tested (in config/config.js) ```js { module: "compliments", position: "lower_third", animateIn: "bounceInDown", animateOut: "bounceOutUp", config: { updateInterval: 500, fadeSpeed: 200, compliments: { anytime: [ "anytime1", "Really ?", "there is...

Why not hard coding this check in main core of MM² before loading config ? in this case, it's +/- related to #3445

`check_config.js` check only syntax but it does not check the contents of the file should we make some other checks on it too ?

So, we have to check `module: `and `position: ` (if defined) we check it on `check_config.js` and MM core ? Personally, I think it's essential to apply the rules to...