MagicMirror-Documentation
MagicMirror-Documentation copied to clipboard
change improve pages target
Now, develop branch is online
So, let's change improve pages target to develop branch
But what happens when we merge develop into the master branch?
Try with a fork?
But the develop branch can already be found here: https://develop.docs.magicmirror.builders/ so why the change?
because it's related to this target:
I think it's better to edit/modify any pages to the develop branch and not in master
Notes:
- It will not read all source file in develop branch
- It's will just change the "help us improve this page!" link
- if
npm startis started on the master branch, it will read master branch files
I think it's better to edit/modify any pages to the develop branch and not in master
Not convinced that this is the use-case for this link. In my opinion, this link is for people that browse the webpage and want to fix a typo or some other error. They want to edit master.
If a developer wants to fix something (add new config options in an upcoming release for example) they would probably not use that link but rather go their normal way with their IDE of choice etc.
Can I close this PR ?
I would say so
will not be implemented