MagicMirror-Documentation icon indicating copy to clipboard operation
MagicMirror-Documentation copied to clipboard

change improve pages target

Open bugsounet opened this issue 2 years ago • 7 comments

Now, develop branch is online

So, let's change improve pages target to develop branch

bugsounet avatar Sep 09 '23 13:09 bugsounet

But what happens when we merge develop into the master branch?

rejas avatar Sep 09 '23 15:09 rejas

Try with a fork?

bugsounet avatar Sep 09 '23 15:09 bugsounet

But the develop branch can already be found here: https://develop.docs.magicmirror.builders/ so why the change?

rejas avatar Sep 10 '23 06:09 rejas

because it's related to this target:

image

I think it's better to edit/modify any pages to the develop branch and not in master

Notes:

  • It will not read all source file in develop branch
  • It's will just change the "help us improve this page!" link
  • if npm start is started on the master branch, it will read master branch files

bugsounet avatar Sep 10 '23 08:09 bugsounet

I think it's better to edit/modify any pages to the develop branch and not in master

Not convinced that this is the use-case for this link. In my opinion, this link is for people that browse the webpage and want to fix a typo or some other error. They want to edit master.

If a developer wants to fix something (add new config options in an upcoming release for example) they would probably not use that link but rather go their normal way with their IDE of choice etc.

rejas avatar Oct 16 '23 21:10 rejas

Can I close this PR ?

bugsounet avatar Jun 20 '24 18:06 bugsounet

I would say so

rejas avatar Jun 20 '24 20:06 rejas

will not be implemented

bugsounet avatar Sep 19 '24 19:09 bugsounet