Dániel Buga comments

Results 578 comments of


                                            Dániel Buga

Remove ChannelCreator types

I'm not happy that `Channel/ChannelTx/ChannelRx` would need to become Peripheral instances. The problem is that they currently have mutable state (as in, their configuration) and I'm not sure how that...

Remove ChannelCreator types

My idea is to move burst mode config to Tx/RxBuffer (and consequently, Preparation if I need to, although burst length is still nebulous to me a bit). This allows us...

Remove ChannelCreator types

> Did you manage to figure out the bandwidth thing? No, I mean I'd put this into the user's hands, so that they can enable burst transfer of buffers. There...

DMA move API tracking issue

I thought we might want to track work that needs to be done in this area, but I'm unsure what that work actually is.

MenuBuilder::add_menu_items panics with "attempt to subtract with overflow" when passed an empty slice

Thanks for finding this. I'm not able to actively work on embedded-menu, but if you're willing to get your hands dirty, I'd be happy to merge and release a fix.

Failes to compile when zerocopys "derive" feature is active

Please take a look at https://github.com/probe-rs/probe-rs/pull/2614

Failes to compile when zerocopys "derive" feature is active

Thanks for the confirmation!

Don't ignore non-existent algorithms in target YAMLs

Maybe, but the issue is open so who knows, someone needs to check ;)

Don't ignore non-existent algorithms in target YAMLs

The check has been added to `Target::new` and it's also present in `ChipFamily::validate` albeit not by calling the same code (`family.get_algorithm`) but implementing the lookup once more. IMO `validate` could...

Don't ignore non-existent algorithms in target YAMLs

Another thing we should do is run the validation logic in `build.rs` so probe-rs doesn't even build if the descriptors aren't all valid.