Dr. Tilmann Bubeck
Dr. Tilmann Bubeck
Thanks for your review! We have currently around 500 keys and will probably get to 700+. "context" could help translators to understand, what the meaning is. We have around 827...
Fine. I will rebase the PR to master, so that it does not use lodash anymore and is easily mergable. Stay tuned.
Rebase done, merge with no problems, no objections or alternative solutions by puzrin. Is there any question open or please merge.
Thanks for the feedback. Awkward, as I tried it out in my project and then cleaned up for PR and obviously made these mistakes. I will come up with an...
Problems fixed, and rebased to current master. Removed lodash. Ready for inclusion or feedback.
`lv_i18n.template.c` is included in the PR (and it is changed to deal with LV_I18N_OPTIMIZE. Instead of `lv_i18n.h` I am using `lv_i18n.template.h`, as this also has to be generated (because it...
First answers > 1. https://github.com/lvgl/lv_i18n/blob/9070d06be9c637a3c169bb183eb491bafbb855e4/src/lv_i18n.template.h#L11-L14 will do > 2. Suffix "_optimized" (`lv_i18n_get_text_optimized`) is not descriptive (it does not explain what happens). I'd suggest something like `lv_i18n_get_text_by_idx` will do > 3....
Next round. Please give me feedback and directions. The following is done: 1. rename `lv_i18n_get_text_optimized()` to `lv_i18n_get_text_by_idx()` 2. remove option `--raw-header`. Instead of specifying a header file name for raw,...
No Problem. Here we are. This is the code also generated for test/c.
next round, please feedback * Plurals not yet done, to first check, that singulars are ok. * index macro is now multiline * code is now _optimize_ and _standard_ at...