Benedikt Tutzer

@ThiloteE huh?

> Very nice to see this implemented! A few comments from my side: > > * I wouldn't bother with the migration of search groups. There is going to be...

Hey @AEgit, this PR brings back the 'floating' mode for search-results and groups. From other issues I know you are quite fond of that feature and you are even sticking...

Thanks a lot for your feedback! > 1. If I do not use the search and just select a group from the groups panel, then the following should happen: >...

Note: The merge with the main branch breaks the search functionality. Investigation is needed.

> The test classes don't compile /home/runner/work/jabref/jabref/src/test/java/org/jabref/logic/pdf/search/retrieval/LuceneSearcherTest.java:94: error: method search in class LuceneSearcher cannot be applied to given types; > > /home/runner/work/jabref/jabref/src/test/java/org/jabref/model/search/rules/GrammarBasedSearchRuleTest.java:31: error: cannot find symbol GrammarBasedSearchRule searchRule = new...

> Please try to keep the current implementation free of the deprecated search flag and introduce a separate parser for the data source to be migrated in the migrations. We...

> I still have the opinion we shouldn't bother with the migration at all. That is basically what was decided in yesterdays devcall. We can get rid of all the...

Hi, Sorry, I am quite busy right now. I would rather clean up the code and do the highlighting for invalid searches before merging. Otherwise people could be confused.

Sorry, should have caught that. But no harm done, it's just a dev branch at the moment anyways.