btlechowski

Results 10 issues of btlechowski

Steps: 1. Clean Install 2. Open about:preferences#sync 3. Choose 'I am new to Sync' 4. Wait till the browser is listed under Devices 5. Click 'Reset Sync...' 6. Choose 'I...

bug
browser-laptop

The NTPSI is served but not shown when expected. Needs additional NTP to be shown ## Steps to Reproduce 1. Clean profile 1. Enable rewards and ads 1. Open NTP...

bug
priority/P3
QA/Yes
release-notes/exclude
feature/ads
OS/Desktop

Follow up to #32875. Issue is still reproducible As long as user touches the screen, the `view` event won't be triggered. User needs to stop touching the screen for `view`...

needs-investigation
priority/P3
QA/Yes
release-notes/exclude
feature/ads
OS/Android

Currently, NTT will not be served nor shown on restored NTP which was just activated (See https://github.com/brave/brave-browser/issues/35889). We could reuse restored NTP to show NTT when the NTP is made...

enhancement
needs-discussion
feature/ads
OS/Desktop

Note: this is only logging related. Purging works properly ### Steps to reproduce 1. Clean profile 1. Run Brave with ``` --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6,"*/whats_new/*"=9 --variations-server-url=https://variations.bravesoftware.com/seed1 --rewards=staging=true,debug=true --use-dev-goupdater-url --enable-features=ShouldAlwaysRunBraveAdsService,ShouldAlwaysTriggerBraveSearchResultAdEvents,ShouldLaunchBraveAdsAsInProcessService,ShouldSupportSearchResultAds,ShouldAlwaysTriggerBraveNewTabPageAdEvents,CustomNotificationAds,NotificationAds:default_ads_per_hour/5,InlineContentAds:maximum_ads_per_day/1 ``` 3. Open...

QA/Yes
feature/ads
OS/Desktop

Note: this is only logging related. Purging works properly ### Steps to reproduce 1. Clean profile 1. Run Brave with ``` --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6,"*/whats_new/*"=9 --variations-server-url=https://variations.bravesoftware.com/seed1 --rewards=staging=true,debug=true --use-dev-goupdater-url --enable-features=ShouldAlwaysRunBraveAdsService,ShouldAlwaysTriggerBraveSearchResultAdEvents,ShouldLaunchBraveAdsAsInProcessService,ShouldSupportSearchResultAds,ShouldAlwaysTriggerBraveNewTabPageAdEvents,CustomNotificationAds,NotificationAds:default_ads_per_hour/5,InlineContentAds:maximum_ads_per_day/1 ``` 3. Open...

QA/Yes
feature/ads
OS/Android
OS/Desktop

### Description Follow up to https://github.com/brave/brave-browser/issues/38373 ### Steps to reproduce 1. Clean profile 1. Run Brave with ``` --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6,"*/whats_new/*"=9 --variations-server-url=https://variations.bravesoftware.com/seed1 --rewards=staging=true,debug=true --use-dev-goupdater-url --enable-features=ShouldAlwaysRunBraveAdsService,ShouldAlwaysTriggerBraveSearchResultAdEvents,ShouldLaunchBraveAdsAsInProcessService,ShouldSupportSearchResultAds,ShouldAlwaysTriggerBraveNewTabPageAdEvents,CustomNotificationAds,NotificationAds:default_ads_per_hour/5,InlineContentAds:maximum_ads_per_day/1 ``` 3. Open NTP 4. Open...

bug
priority/P2
QA/Yes
release-notes/exclude
feature/ads
OS/Desktop

### Description Follow up to https://github.com/brave/brave-browser/issues/38373 ### Steps to reproduce 1. Clean profile 1. Run Brave with ``` --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6,"*/whats_new/*"=9 --variations-server-url=https://variations.bravesoftware.com/seed1 --rewards=staging=true,debug=true --use-dev-goupdater-url --enable-features=ShouldAlwaysRunBraveAdsService,ShouldAlwaysTriggerBraveSearchResultAdEvents,ShouldLaunchBraveAdsAsInProcessService,ShouldSupportSearchResultAds,ShouldAlwaysTriggerBraveNewTabPageAdEvents,CustomNotificationAds,NotificationAds:default_ads_per_hour/5,InlineContentAds:maximum_ads_per_day/1 ``` 3. Open NTP 4. Open...

QA/Yes
feature/ads
OS/Android

The generation seed job should fail, but it passes. Then in the client the seed is not applied: ``` [27107:259:1109/120010.074659:VERBOSE1:processed_study.cc(98)] BraveSearchAdStudy has a repeated experiment name Enabled ``` cc @atuchin-m...

Currently ads will not show prior to Windows 10 version 1803, build 17134 and Mac prior to 10.14 We need to enable custom ad notifications so that user start receiving...