Bryan Talbot

docker hub repo is missing

26

Maybe it got removed by mistake? https://hub.docker.com/r/frolvlad/alpine-oraclejdk8/ The JRE repo is still there at the expected location: https://hub.docker.com/r/frolvlad/alpine-oraclejre8/

Order keys for s3

1

As reported in #90 there is a bug with key ordering when computing S3 keys. The bug reporter submitted a PR #91 which was never accepted. Maybe the use of...

enable S3 ServerSideEncryption for all writes. S3 doesn't charge any extra for using encryption and there's no reason not to. AES256 using the S3 managed keys are used by default...

... so that it doesn't need to be named 'mapbox'. The bucket named by the ENV variable BackupBucket will be used. BackupBucket is set to 'mapbox' in test/env.js which is...

x-amz-json-1.0 not properly serializing error responses

5

The errors from ElasticMQ (1.5.1) when using the `application/x-amz-json-1.0` content-type are incomplete. The errors returned seem to resolve to just `Sender` which is not really helpful and cause the AWS...

nonce is optional in callback

13

In releases before 1.3, the nonce appearing in the id_token was optional and if present was required to be equal to the nonce in the session['omniauth.nonce'] value. That changed in...

Also, default trust_root if option is not set to be the return_to domain which seems like the right thing to do in most cases anyway.

dead project?

1

Is this project dead or does it just appear that way due to lack of commits and PR response?

The registration_path must include the SCRIPT_NAME when it exists to allow requests to be seen as properly `on_path?` and to be routed to the correct rack app. Additionally, the private...

Rack sets SCRIPT_NAME when a path is mapped to an app. So, a rack app built like below will route all requests starting with `/myapp` to MyApp and everything else...