Brian Sweeney

Results 826 comments of Brian Sweeney

This is due to how [fixed-position elements are collected](https://github.com/dompdf/dompdf/blob/v1.1.1/src/FrameReflower/Page.php#L119) for rendering, the assumption appearing to be that they would be declared on the first page. Can probably be fixed in...

> > Note: the 20141028 version of the spec was used because the section numbering matches up with existing references in code. The relevant section for the living HTML5 spec...

Do you have plans to address the other instances where this notice arises? 3521 has a list of problematic functions.

I've already patched up what I found based on running my own local tests as well as searching using the regex provided in 3521. I just wanted to know if...

Apologies things have been ... hectic. I will try to get to it over the next week.

#3521 beat me to the change so I'm closing this PR in favor of that one. Thanks for surfacing the compatibility issue.

> `follow_location` does not work under certain circumstances Under what circumstances? Follow location is [disabled by default](https://github.com/dompdf/dompdf/blob/v3.0.0/src/Options.php#L350-L355). When enabled, under what circumstances does it not work with `file_get_contents`? > `Helpers::encodeURI`...

Thanks for the info. The change seems fine on first look. I'll let you know if I have any feedback once I have a chance to mull it over.

I don't think the issue is with Helpers::encodeURI. When I run that sample URL through the method it returns without any changes (in the latest release). Using the URL in...

FYI while I'd like to confirm the issues with the in-built logic, I'll move forward with the change regardless since curl is generally more robust.