Brian Sweeney

Results 826 comments of Brian Sweeney

I'm working on an update to the library now.

Sounds like maybe an issue with php-svg-lib not resetting a state value in the PDF.

It looks like the issue is incorrect handling of a value of none, which is treated the same as if you had provided an actual dash array specification. The issue...

I'll make a few minor changes once you have a chance to review my comments and make any necessary changes. I noted a few issues I'd like to address separately...

Happy to take a look.

Thanks for keeping this alive. I'm hoping to switch to working on a release for FontLib in the near future.

If the issue is around construction of a namespace in a string, you might also look at the [Dompdf project](https://github.com/dompdf).

I'm curious why only these lines prove problematic. There is similar logic in elsewhere in FontLib as well as in Dompdf that builds a string containing a class reference. I...

> Maybe. There are no more moments like this in this library? In the file you modified there's [this block](https://github.com/dompdf/php-font-lib/blob/1.0.1/src/FontLib/TrueType/File.php#L419-L430): ``` if (!self::$raw) { $name_canon = preg_replace("/[^a-z0-9]/", "", strtolower($tag)); $class...

You are correct. As noted there is a [class for each supported table](https://github.com/dompdf/php-font-lib/tree/master/src/FontLib/Table/Type) and the gsub table is not among them. I'll need to review the spec for the gsub...