Brian Sweeney

Results 826 comments of Brian Sweeney

@glennmcewan do you have sample HTML+CSS that reproduces the issue? Still plan to patch the issue, but I'm always on the lookout for unintended consequences (e.g., are we mishandling a...

That error has nothing to do with the `@page` declaration. It looks like you're running that PHP through the debug helper based on this message: > PHP Notice: assigning identifier...

Ok yes thanks for that I can reproduce. Odd that setting the page margin within a particular range results in the error, but that outside that range (higher or lower)...

FYI #2503 prevents the crash but doesn't address the underlying issue. Starting with page three the width of one of the elements is lost and the rendering breaks down. The...

Ah ok. Are you saying you want to adjust the margin of the household element based on whether it is the first one on the page? Currently Dompdf doesn't re-evaluate...

We have seen some corruption of this type with other fonts. I'm seeing it in my test bed using versions as low as 0.8.4. I believe a temporary work-around, at...

This is interesting and has me wondering if it is the cause of #2054.

Apparently I made this change in 7f170fb340d6f317ec5203862a25b3858de0e10e. I didn't link to any issues nor provide any guidance in the commit message so I'm not sure why I made that change....

I probably added this in order to perform some type of URL normalization, similar to what most web browsers do (relevant on SO: https://stackoverflow.com/a/11071438/264628) because file_get_contents can be strict in...