Brian Sweeney
Brian Sweeney
I wouldn't want to mess with the class file in order to avoid any potential issues with the modification. Using an external file to store local defaults should be fine,...
You're welcome to hack at it if you want. Just submit a PR when you're done and I'll review and make any changes I think might improve it.
> ...it seems all lines are shifted compared to the old rendering, depending on the font and line height. Ah, yes. I wasn't taking into account the line height when...
In addition to the line height issue I noticed an alignment problem when an inline-block element has multiple lines. Based on some testing vertical alignment should be against, nominally, the...
OK I pushed an updated commit that, though there are some placements that aren't quite right, I think gets us close enough to the expected rendering. I do think some...
I did find an issue but I'm not sure, yet, if it's because one of the calculations is bad or because a value isn't updated. The calculation to determine if...
> I did find an issue but I'm not sure, yet, if it's because one of the calculations is bad or because a value isn't updated. The calculation to determine...
OK, I think I've done enough with this for the next release.
> I am noticing a difference compared to the current master branch that appears to be a bug, in relation to line-height on ancestor elements. It looks like the issue...
OK, this latest branch refresh addresses those issues. There is one regression in the branch for which I don't see an easy resolution. The minimum height of a frame enclosing...