Brandon Surmanski

From code comments, the range is supposed to be between -1 to 1 for most noises. I believe the current ranges are a bug. I fixed the perlin ranges here:...

I recently created a unit test for the core perlin functions: https://github.com/bsurmanski/noise-rs/blob/4caa1145eac4adb6a4d46c5b9fd498e59b34e2d1/src/core/perlin.rs#L408 I get a range between -1 and 1. I tried running the exact code provided, and it returned...

I am also running into https://github.com/tokio-rs/prost/issues/504, which seems to be an unrelated but similar issue with path matching.

Looks like the code generator (https://github.com/tokio-rs/prost/blob/d45a37cab69c2a0cda36a97df8823fcaf43dc1fe/prost-build/src/code_generator.rs#L185) has access to both the DescriptorProto or FieldDescriptorProto as well as the Config at the appropriate place. So adding a visitor likely wouldn't require...

Hmm, I was making a quick mock up of the proposed solution and ran into a couple of ambiguities: 1) enums use a EnumDescriptorProto, but call append_type_attributes 2) Oneofs use...

It seems like the ServiceGenerator uses a AST [Service](https://github.com/tokio-rs/prost/blob/d7324c4bd43b491b728545ed90a325675a3966e4/prost-build/src/ast.rs#L110) struct, even though a [ServiceDescriptorProto](https://github.com/tokio-rs/prost/blob/28e4522f8ae738d4574cce104da6fd88d9ce0c14/prost-build/third-party/protobuf/include/google/protobuf/descriptor.proto#L285) exists. It seems the AST struct also provides the proto name, package, and comments but is...

This would be very convenient when trying to mix Prost with serde. GRPC enums are represented as strings. For example, a failed request might look like: ```json { "error": {...

I seem to be running into this in 0.9.0. Here's a simple example: ```proto syntax = "proto3"; package mydemo; message Outter { oneof inner_oneof { float inner_field_float = 1; string...

After some experimentation, if there is a leading dot, the annotations will be applied to the oneof fields. So, to fix my example, use: `config.field_attribute("mydemo.Outter.inner_oneof", "#[serde(flatten)]"); `. Note, no leading...

This would make sense as a separate DS app. You're looking for: https://github.com/rhaleblian/dslibris