Brent Shaffer issues

Results 184 issues of


                                            Brent Shaffer

PHP: Linting errors from Doctum

I've received the following linting errors for PHP classes when running the [build-protobuf-docs.sh](https://github.com/googleapis/gax-php/blob/main/dev/sh/build-protobuf-docs.sh) to generate the reference documentation ``` ERROR: Invalid @param tag on "pack": "message: A proto message." on...

PHP: Linting errors for PHPStan (Level 0)

I have run https://phpstan.org/ on the PHP classes in `php/src/` at the [least strict level](https://phpstan.org/user-guide/rule-levels) (level 0), meaning only the following very important issues are reported: > basic checks, unknown...

feat: more readable phpdoc escaping

The PHPDoc escaping in PHP is aggressive in that it escapes some character sequences that don't need to be escaped (`/*`), and it uses HTML entities to escape others (`*/`...

[PHP] option exclude backwards compatible proto files

For PHP all nested messages generate two classes, the current namespaced class and a file to support backwards compatibility with the previous non-namespaced files. There's also a `class_alias` call at...

php

cleanup

release notes: yes

fix: php 8.2 dynamic property warning in MapFieldIter

addresses #11243 Defines `$key_type` in `MapFieldIter`, so as not to trigger PHP 8.2 warning. Note that this will change the visibility of `$key_type` from public in previous versions to private...

what is the recommended way to handle deprecations?

I assume since it's neither a feat or a fix, the recommended way to handle deprecations would be `chore(deprecation):` or simply `chore: deprecate such and such`. But would a `deprecated:`...

Enums for Protobuf PHP?

PHP 8.1 brought us [Enumerations](https://www.php.net/manual/en/language.enumerations.php), which are absolutely perfect for use in Protobuf. Specifically, backed Enumerations would bring us exactly what we want: ```php enum Status: int { case STATUS_UNDEFINED...

php

Brent Shaffer